New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dpnp.flatten #1825

Merged

antonwolfy merged 6 commits into master from fix_flatten

May 17, 2024

Collaborator

npolina4 commented May 14, 2024

dpnp.flatten does not work for not default queue because sycl_device and sycl_queue cannot be provide together.
This is fixed by this PR

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?


          Fix dpnp.flatten

9a85ed1

npolina4 requested review from vlad-perevezentsev, antonwolfy and vtavana

May 14, 2024 16:26

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_array.py Outdated Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_array.py Outdated Show resolved Hide resolved

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_array.py Show resolved Hide resolved

Contributor

github-actions bot commented May 14, 2024 •

edited

Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_array.py Show resolved Hide resolved


          Fix docs

c58156a

antonwolfy reviewed

View reviewed changes

dpnp/dpnp_array.py Outdated Show resolved Hide resolved

dpnp/dpnp_array.py Outdated Show resolved Hide resolved

dpnp/dpnp_array.py Show resolved Hide resolved

npolina4 and others added 3 commits

May 14, 2024 13:40


          Update dpnp/dpnp_array.py

2dd1007

Co-authored-by: Anton <[email protected]>


          Update dpnp/dpnp_array.py

ea662c6

Co-authored-by: Anton <[email protected]>


          Update dpnp/dpnp_array.py

10907bf

Co-authored-by: Anton <[email protected]>

antonwolfy approved these changes

View reviewed changes

Contributor

antonwolfy left a comment

LGTM! Thank you @npolina4


          Merge branch 'master' into fix_flatten

af5c0e5

antonwolfy merged commit d0d26b4 into master

42 of 49 checks passed

antonwolfy deleted the fix_flatten branch

May 17, 2024 11:04

github-actions bot added a commit that referenced this pull request


          Fix dpnp.flatten (#1825)

6decb88

* Fix dpnp.flatten

* Fix docs

* Update dpnp/dpnp_array.py

Co-authored-by: Anton <[email protected]>

* Update dpnp/dpnp_array.py

Co-authored-by: Anton <[email protected]>

* Update dpnp/dpnp_array.py

Co-authored-by: Anton <[email protected]>

---------

Co-authored-by: Anton <[email protected]> d0d26b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet