Implement outer for element-wise functions #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
approved these changes
May 10, 2024
antonwolfy
reviewed
May 10, 2024
antonwolfy
reviewed
May 11, 2024
antonwolfy
reviewed
May 11, 2024
There was a problem hiding this comment.
In general it's quite a mix of updating different functionality in one PR.
It would be much more better to split into 3 parts by affecting functionality, like updates in:
- dpnp.flatten
- ufunc.outer
- dpnp.outer
Or at least it would be very helpful to describe all the changes with more details in the PR's description.
antonwolfy
reviewed
May 20, 2024
antonwolfy
approved these changes
May 20, 2024
There was a problem hiding this comment.
Thank you @npolina4 No more comment from me.
Adding documentation page for ufunc should be handled by a separate PR,
github-actions bot
added a commit
that referenced
this pull request
May 21, 2024
* Add ufunc outer * Update dpnp.outer * Changed flatten to ravel in outer function to avoid unnecessary copy * Update flatten implementation * Update docs for outer * address comments * Update dpnp/dpnp_algo/dpnp_elementwise_common.py --------- Co-authored-by: Anton <[email protected]> d7400a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented outer for binary element-wise functions.
Updated dpnp.outer by using new ufunc outer (dpnp.multiply.outer)
Added tests for different shape and tests compare for compare with dpnp.outer.