Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend pre-commit hooks with codespell #1798

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Extend pre-commit hooks with codespell #1798

merged 2 commits into from
Apr 22, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 22, 2024 •
edited
Loading

The PR add a pre-commit hook with codespell check to identify possible common misspelling in the code.

Note, the versions of other hooks were updated to the latest releases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This pre-commit hook will be helpful for us.
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit a8e6fce into master Apr 22, 2024
51 of 56 checks passed
@antonwolfy antonwolfy deleted the add-codespell-to-pre-commit branch April 22, 2024 19:24
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 22, 2024
@github-actions
Extend pre-commit hooks with codespell (IntelPython#1798)
6e3e4dc 
* Extend pre-commit hooks with codespell

* Stepped versions of pre-commit hooks to the latest releases a8e6fce
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev