-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of dpnp.histogram
#1785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
impl_histogram
branch
from
April 22, 2024 12:01
ddd622c
to
49074de
Compare
antonwolfy
force-pushed
the
impl_histogram
branch
from
April 24, 2024 10:47
49074de
to
dd6e322
Compare
vtavana
reviewed
Apr 25, 2024
vlad-perevezentsev
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Apr 29, 2024
* Implement dpnp.histogram * Updated third party tests for histogram * Updated histogram tests due to new dpnp.cumsum() impl * Applied pre-commit checks * Added dpnp tests * Added CFD tests * Renamed test_histogram.py * Updated tests to run on Iris Xe * Get rid of block size * Addressed review comments * Leftovers from rebase * Cast bin edges to default floating type if density is enabled 8d04592
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 29, 2024
* Implement dpnp.histogram * Updated third party tests for histogram * Updated histogram tests due to new dpnp.cumsum() impl * Applied pre-commit checks * Added dpnp tests * Added CFD tests * Renamed test_histogram.py * Updated tests to run on Iris Xe * Get rid of block size * Addressed review comments * Leftovers from rebase * Cast bin edges to default floating type if density is enabled 8d04592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is about to add implementation of
dpnp.histogram
function.In the first step there is no dedicated kernel for uniform bins, since no
bincount
available in dpnp, but TODO comment placed to implement that later.