Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dpnp.kron implementation #1732

Merged
merged 2 commits into from
Feb 25, 2024
Merged

update dpnp.kron implementation #1732

merged 2 commits into from
Feb 25, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 24, 2024

In this PR, dpnp.kron implementation is updated.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review February 24, 2024 04:09
antonwolfy
antonwolfy reviewed Feb 24, 2024
View reviewed changes
tests/test_product.py Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Show resolved Hide resolved
tests/test_product.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me. Thank you @vtavana

@antonwolfy antonwolfy merged commit 3e251c8 into master Feb 25, 2024
44 of 45 checks passed
@antonwolfy antonwolfy deleted the dpnp_kron branch February 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy