Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring #1727

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Implemented dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring #1727

merged 2 commits into from
Feb 22, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 21, 2024 •
edited
Loading

This PR adds compute follows data keywords to dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring functions.
The implementation relies on appropriate NumPy functions where the result is coerced to a DPNP array through dpnp.asarray call with device aware keywords passed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

vtavana
vtavana reviewed Feb 22, 2024
View reviewed changes
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
vtavana
vtavana approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 8fa2166 into master Feb 22, 2024
45 checks passed
@antonwolfy antonwolfy deleted the from_like_functions branch February 22, 2024 16:28
github-actions bot added a commit that referenced this pull request Feb 22, 2024
@github-actions
Implemented dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring (#1727)
c3a8f06 
* Implemented dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring

* Address the comments 8fa2166
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 22, 2024
@github-actions
Implemented dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring (Intel…
236562c 
…Python#1727)

* Implemented dpnp.frombuffer, dpnp.fromfile and dpnp.fromstring

* Address the comments 8fa2166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana