Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dpctl cmake config #1671

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Use dpctl cmake config #1671

merged 2 commits into from
Feb 1, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 29, 2024 •
edited
Loading

The PR propose to adapt to the dpctl service improvement from dpctl#1508 which making find_package(Dpctl) works out of the box with dpctl installed in the Python environment.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@antonwolfy antonwolfy marked this pull request as ready for review February 1, 2024 10:27
vlad-perevezentsev
vlad-perevezentsev approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 8cde6c4 into master Feb 1, 2024
42 of 45 checks passed
@antonwolfy antonwolfy deleted the use_dpctl_build_config branch February 1, 2024 13:37
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 1, 2024
@github-actions
Use dpctl cmake config (IntelPython#1671) 8cde6c4
1dc522a
@vtavana vtavana mentioned this pull request Feb 2, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev