Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_argsort_test #1667

Merged
merged 1 commit into from
Jan 25, 2024
Merged

update_argsort_test #1667

merged 1 commit into from
Jan 25, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 24, 2024

In this PR, a few test related to dpnp.argsort are updated.

dpnp.argsort output is always "stable" (which means the returned indices must maintain the relative order of input values which compare as equal) but for NumPy its not necessary "stable".
In the updated tests, random floating numbers are generated, and when their data type is changed to integer type to align with requested data type of the test, we may encounter with repetitive numbers in the input array for which "stable" condition plays a role.
"stable" flag is added to the tests to make sure NumPy also always returns the stable result.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review January 25, 2024 02:25
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for resolving that!

@vtavana vtavana merged commit 66f995b into master Jan 25, 2024
45 checks passed
@vtavana vtavana deleted the use_stable_flag_argsort_test branch January 25, 2024 14:23
github-actions bot added a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants