Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of missing arguments in dpnp.amax and dpnp.amin #1639

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 8, 2023

The PR aligns supported arguments of dpnp.amax and dpnp.amin with numpy implementation.
The functions are only aliased on already updated dpnp.max and dpnp.min methods.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit d090de9 into master Dec 11, 2023
44 of 45 checks passed
@antonwolfy antonwolfy deleted the amin_amax_keepdims branch December 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants