Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dpnp.indices function #1622

Merged
merged 14 commits into from
Jan 16, 2024
Merged

Update dpnp.indices function #1622

merged 14 commits into from
Jan 16, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Nov 7, 2023

Added all dimensions, sparse, and dtype support. Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Nov 7, 2023

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 LGTM!

* Implement dpnp.mgrid and dpnp.ogrid function

* address comments

* address comments

* Skip dtype check for Iris Xe

* Update test_ranges.py

* Added description of all parameters
@antonwolfy antonwolfy merged commit c4b3b2e into master Jan 16, 2024
44 of 45 checks passed
@antonwolfy antonwolfy deleted the implement_indices branch January 16, 2024 11:01
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Jan 16, 2024
* Update dpnp.indices function

* Clean up dpnp_indices

* address comments

* address comments

* cancel changes for test_indices_list3

* Added description of all parameters

* Implement dpnp.mgrid and dpnp.ogrid function (IntelPython#1633)

* Implement dpnp.mgrid and dpnp.ogrid function

* address comments

* address comments

* Skip dtype check for Iris Xe

* Update test_ranges.py

* Added description of all parameters

* Resolve pre-commit issue

---------

Co-authored-by: Anton <[email protected]>
Co-authored-by: Anton Volkov <[email protected]> c4b3b2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants