implement dpnp.max and dpnp.min using dpctl.tensor functions #1602

vtavana · 2023-10-18T16:15:21Z

In this PR, dpnp.max and dpnp.min are implemented using their dpctl.tensor counterparts.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?

github-actions · 2023-10-18T16:53:11Z

View rendered docs @ https://intelpython.github.io/dpnp/index.html

dpnp/dpnp_array.py

tests/skipped_tests.tbl

dpnp/dpnp_iface_statistics.py

tests/test_statistics.py

dpnp/dpnp_iface_statistics.py

tests/test_amin_amax.py

dpnp/dpnp_iface_statistics.py

antonwolfy

Great! Thank you @vtavana

tests/test_statistics.py

vtavana self-assigned this Oct 18, 2023

vtavana marked this pull request as ready for review October 18, 2023 18:24

vtavana requested review from antonwolfy, vlad-perevezentsev and npolina4 October 18, 2023 18:24

vtavana changed the title ~~implement dpnp.max and dpnp.max using dpctl.tensor functions~~ implement dpnp.max and dpnp.min using dpctl.tensor functions Oct 18, 2023

vtavana force-pushed the max_min branch from 142aa43 to 03276b7 Compare October 22, 2023 17:00

antonwolfy reviewed Oct 25, 2023

View reviewed changes

antonwolfy reviewed Oct 26, 2023

View reviewed changes

dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved

antonwolfy reviewed Oct 30, 2023

View reviewed changes

dpnp/dpnp_iface_statistics.py Show resolved Hide resolved

dpnp/dpnp_iface_statistics.py Show resolved Hide resolved

vtavana force-pushed the max_min branch from 67cb7b4 to 07a5ca0 Compare October 30, 2023 16:42

antonwolfy approved these changes Oct 30, 2023

View reviewed changes

tests/test_statistics.py Outdated Show resolved Hide resolved

vtavana force-pushed the max_min branch from 07a5ca0 to d76883f Compare October 31, 2023 17:09

vtavana added 7 commits November 7, 2023 13:55

implement dpnp.max and dpnp.min using dpctl.tensor functions

7c85977

address comments

f6993d0

fix a few issues

233e4fc

fix doc-string

cb7e686

add axis==None condition for zero-size array

f89b813

add new tests to improve coverage

28f4fe9

update tests to reduce duplication

9bbdbdf

vtavana force-pushed the max_min branch from d76883f to 9bbdbdf Compare November 7, 2023 23:38

vtavana merged commit 79cb518 into master Nov 8, 2023
35 checks passed

vtavana deleted the max_min branch November 8, 2023 04:38

antonwolfy mentioned this pull request Jan 9, 2024

Merge 0.13.1dev1 from master to gold #1653

Merged

vtavana mentioned this pull request Jan 17, 2024

Replace numpy._NoValue to default value for min and max functions #1572

Closed

6 tasks

vlad-perevezentsev mentioned this pull request Jun 26, 2024

Statistical kernels are not supported on integrated graphics #1325

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement dpnp.max and dpnp.min using dpctl.tensor functions #1602

implement dpnp.max and dpnp.min using dpctl.tensor functions #1602

vtavana commented Oct 18, 2023

github-actions bot commented Oct 18, 2023 •

edited

Loading

antonwolfy left a comment

implement dpnp.max and dpnp.min using dpctl.tensor functions #1602

implement dpnp.max and dpnp.min using dpctl.tensor functions #1602

Conversation

vtavana commented Oct 18, 2023

github-actions bot commented Oct 18, 2023 • edited Loading

antonwolfy left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2023 •

edited

Loading