Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework implementation of diag, diagflat, vander, and ptp #1579

Merged
merged 7 commits into from
Nov 20, 2023
Merged

rework implementation of diag, diagflat, vander, and ptp #1579

merged 7 commits into from
Nov 20, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 6, 2023

In this PR, device, usm_type, and sycl_queue keywords are added to dpnp.diag, dpnp.diagflat, dpnp.ptp and dpnp.vander.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 6, 2023
@vtavana vtavana force-pushed the diag_vander_ptp_trace branch 2 times, most recently from c450aae to edaca90 Compare October 7, 2023 04:20
@vtavana vtavana marked this pull request as ready for review October 7, 2023 14:40
npolina4
npolina4 reviewed Oct 9, 2023
View reviewed changes
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Oct 10, 2023
View reviewed changes
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
tests/skipped_tests_gpu.tbl Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
@antonwolfy
Copy link
Contributor

please merge the master branch into PR and resolve the conflicts

@vtavana vtavana force-pushed the diag_vander_ptp_trace branch 2 times, most recently from e0b9f89 to 13f98c9 Compare October 22, 2023 16:51
@vtavana vtavana changed the base branch from master to max_min October 22, 2023 16:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 25, 2023
View reviewed changes
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
tests/third_party/cupy/core_tests/test_ndarray_reduction.py Show resolved Hide resolved
Base automatically changed from max_min to master November 8, 2023 04:38
@vtavana vtavana requested a review from npolina4 November 8, 2023 17:59
antonwolfy
antonwolfy approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana !

@vtavana vtavana merged commit 5bcf910 into master Nov 20, 2023
36 of 43 checks passed
@vtavana vtavana deleted the diag_vander_ptp_trace branch November 20, 2023 20:51
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 npolina4 approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @antonwolfy @npolina4