Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dpnp.logaddexp #1561

Merged
merged 3 commits into from
Oct 2, 2023
Merged

implement dpnp.logaddexp #1561

merged 3 commits into from
Oct 2, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 17, 2023

In this PR, dpnp.logaddexp is implemented using its counterpart in dpctl, i.e., dpctl.tensor.loagaddexp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 17, 2023 22:21
vlad-perevezentsev
vlad-perevezentsev approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you @vtavana

@vtavana vtavana merged commit d76d44e into master Oct 2, 2023
21 checks passed
@vtavana vtavana deleted the logaddexp_dpctl_to_dpnp branch October 2, 2023 23:29
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @vlad-perevezentsev