Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dpctl.tensor.sign and dpctl.tensor.negative in dpnp #1523

Merged
merged 3 commits into from
Aug 22, 2023
Merged

use dpctl.tensor.sign and dpctl.tensor.negative in dpnp #1523

merged 3 commits into from
Aug 22, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 16, 2023 •
edited
Loading

The PR uses dpctl.tensor implementation for dpnp.sign and dpnp.negative functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the use_dpctl_sign_negative_in_dpnp branch from 8f3c37c to f171c56 Compare August 19, 2023 03:41
@vtavana vtavana marked this pull request as ready for review August 19, 2023 03:41
@vtavana vtavana force-pushed the use_dpctl_sign_negative_in_dpnp branch 2 times, most recently from 32cfe1e to c259d1c Compare August 19, 2023 03:52
antonwolfy
antonwolfy reviewed Aug 21, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_algo/dpnp_elementwise_common.py Show resolved Hide resolved
tests/skipped_tests_gpu.tbl Show resolved Hide resolved
@vtavana vtavana force-pushed the use_dpctl_sign_negative_in_dpnp branch 4 times, most recently from ce3d7b7 to dc2d24c Compare August 21, 2023 21:44
antonwolfy
antonwolfy reviewed Aug 21, 2023
View reviewed changes
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the use_dpctl_sign_negative_in_dpnp branch from dc2d24c to 597ddbc Compare August 21, 2023 23:51
@vtavana vtavana force-pushed the use_dpctl_sign_negative_in_dpnp branch from 597ddbc to 096857c Compare August 22, 2023 14:26
antonwolfy
antonwolfy approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana LGTM!

@vtavana vtavana merged commit 79ac2b0 into master Aug 22, 2023
26 checks passed
@vtavana vtavana deleted the use_dpctl_sign_negative_in_dpnp branch August 22, 2023 16:17
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy