Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_dpctl_rounding_funcs_in_dpnp #1518

Merged
merged 5 commits into from
Aug 18, 2023
Merged

use_dpctl_rounding_funcs_in_dpnp #1518

merged 5 commits into from
Aug 18, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 10, 2023 •
edited
Loading

The PR changes the implementation of dpnp.ceil, dpnp.floor, and dpnp.trunc. These functions now invoke oneapi::mkl::vm::ceil, oneapi::mkl::vm::ceil, and oneapi::mkl::vm::ceil from pybind11 extension of OneMKL VM, respectively, if possible or uses dpctl.tensor implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the use_dpctl_rounding_funcs branch 2 times, most recently from 1a19320 to 863c2e7 Compare August 10, 2023 23:45
@vtavana vtavana marked this pull request as ready for review August 11, 2023 16:42
@vtavana vtavana force-pushed the use_dpctl_rounding_funcs branch 4 times, most recently from 677c5e7 to 342b3a4 Compare August 11, 2023 23:52
@vlad-perevezentsev
Copy link
Collaborator

@vtavana could you also update class TestCeil / TestFloor / TestTrunc in test_mathematical.py to run them on Iris Xe?

@vtavana
Copy link
Collaborator Author

vtavana commented Aug 14, 2023

@vtavana could you also update class TestCeil / TestFloor / TestTrunc in test_mathematical.py to run them on Iris Xe?

done

@vtavana vtavana force-pushed the use_dpctl_rounding_funcs branch 2 times, most recently from 46d16a5 to f6b87a6 Compare August 14, 2023 18:16
antonwolfy
antonwolfy reviewed Aug 16, 2023
View reviewed changes
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the use_dpctl_rounding_funcs branch 3 times, most recently from e46ecd9 to 836ec09 Compare August 17, 2023 05:26
antonwolfy
antonwolfy reviewed Aug 17, 2023
View reviewed changes
tests/skipped_tests_gpu_no_fp64.tbl Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_rounding.py Show resolved Hide resolved
vlad-perevezentsev
vlad-perevezentsev approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Many thanks @vtavana

@vtavana vtavana merged commit 18da200 into master Aug 18, 2023
25 of 26 checks passed
@vtavana vtavana deleted the use_dpctl_rounding_funcs branch August 18, 2023 17:19
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @vlad-perevezentsev @antonwolfy