Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed w/a to Klocwork #1493

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Removed w/a to Klocwork #1493

merged 2 commits into from
Jul 21, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 21, 2023

The PR removes workaround to Klocwork implemented in #1433.
Due to transition to Coverity tool, the w/a is no longer necessary.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@oleksandr-pavlyk
Copy link
Contributor

Note that LD_LIBRARY_PATH currently still needs to be modified: See IntelPython/dpctl#1282

It might make sense to add this change in a separate PR to dpnp'd build.sh.

@antonwolfy
Copy link
Contributor Author

Note that LD_LIBRARY_PATH currently still needs to be modified: See IntelPython/dpctl#1282

It might make sense to add this change in a separate PR to dpnp'd build.sh.

Thanks you for the note. I agree that adding the change in a separate PR with python 3.11 support looks more clear.

@antonwolfy antonwolfy merged commit 1fc100f into master Jul 21, 2023
@antonwolfy antonwolfy deleted the revert-kw-workaround branch July 21, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants