Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_linalg.py to run on Iris Xe #1474

Merged
merged 13 commits into from
Jul 13, 2023
Merged

Update test_linalg.py to run on Iris Xe #1474

merged 13 commits into from
Jul 13, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR solves updates tests and backend of some linalg functions to run on Iris Xe which does not support double precision floating point type.
It solves part of #1293

Also I have checked #1005 and did not find raising 2 errors during the run on CPU.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 12, 2023
antonwolfy
antonwolfy reviewed Jul 12, 2023
View reviewed changes
dpnp/backend/kernels/dpnp_krnl_common.cpp Outdated Show resolved Hide resolved
dpnp/backend/kernels/dpnp_krnl_common.cpp Outdated Show resolved Hide resolved
tests/test_linalg.py Show resolved Hide resolved
dpnp/linalg/dpnp_algo_linalg.pyx Outdated Show resolved Hide resolved
dpnp/backend/kernels/dpnp_krnl_linalg.cpp Outdated Show resolved Hide resolved
tests/test_linalg.py Outdated Show resolved Hide resolved
tests/test_linalg.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev merged commit 771653b into IntelPython:master Jul 13, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the fix_iface_linalg branch August 10, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy