Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dpnp.cos() and dpnp.sin() implementations #1471

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Improve dpnp.cos() and dpnp.sin() implementations #1471

merged 3 commits into from
Jul 7, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 7, 2023 •
edited
Loading

The new logic assumes to call cos and sin from pybind11 extension of OneMKL VM if possible or fully rely on dpctl.tensor implementation otherwise.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 7, 2023
vlad-perevezentsev
vlad-perevezentsev reviewed Jul 7, 2023
View reviewed changes
dpnp/backend/extensions/vm/vm_py.cpp Outdated Show resolved Hide resolved
dpnp/backend/extensions/vm/vm_py.cpp Outdated Show resolved Hide resolved
vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @antonwolfy

@antonwolfy antonwolfy merged commit f82cdc4 into master Jul 7, 2023
@antonwolfy antonwolfy deleted the dpctl_sin_cos branch July 7, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev