Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.sqrt using dpctl and OneMKL implementations #1470

Merged
merged 9 commits into from
Jul 8, 2023
Merged

Update dpnp.sqrt using dpctl and OneMKL implementations #1470

merged 9 commits into from
Jul 8, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Jul 7, 2023 •
edited by antonwolfy
Loading

This PR adds the ability to rely on dpctl.tensor.sqrt() implementation for dpnp.sqrt function and call sqrt from pybind11 extension of OneMKL if possible

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 7, 2023
antonwolfy
antonwolfy reviewed Jul 7, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_algo.pxd Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
tests/test_umath.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @vlad-perevezentsev !

antonwolfy
antonwolfy approved these changes Jul 7, 2023
View reviewed changes
dpnp/backend/extensions/vm/vm_py.cpp Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 7, 2023
View reviewed changes
dpnp/backend/extensions/vm/vm_py.cpp Outdated Show resolved Hide resolved
@antonwolfy antonwolfy merged commit fd9ce2b into IntelPython:master Jul 8, 2023
@antonwolfy antonwolfy mentioned this pull request Jul 10, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy