Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse dpctl.tensor.floor_divide() function. #1462

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Reuse dpctl.tensor.floor_divide() function. #1462

merged 4 commits into from
Jul 11, 2023

Conversation

npolina4
Copy link
Collaborator

Reused dpctl.tensor.floor_divide() function.
Fixed crash for device without support double precision.
Added tests.

The PR is about to close #1404.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy
antonwolfy approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 ! LGTM!

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
@npolina4 npolina4 merged commit 10a656d into master Jul 11, 2023
@npolina4 npolina4 deleted the reuse_floor_divide_func branch July 11, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpnp.floor_divide() crash
2 participants
@npolina4 @antonwolfy