Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _depenv_s in dpnp/backend on Windows #1452

Conversation

vlad-perevezentsev
Copy link
Collaborator

This RP refactors use_sycl_device_memory and is_verbose_mode functions to solve SAT-5868 and suggest the usage of _dupenv_s for Windows by conditional compilation.

Also this PR removes --version argument for clang-format hook due to pre-commit-hooks/issues/44

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev merged commit b2f116a into IntelPython:master Jun 23, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the fix_deprecated_warning branch June 23, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants