Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal dpnp kernel instead of MKL if no FP64 support #1386

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 20, 2023

OneMKL VM functions copy data to the host when a device doesn't provide support of fp64, which might impact the performance.
The PR propose to use internal DPNP kernel instead of VM function from OneMKL in that case.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 20, 2023
@antonwolfy antonwolfy merged commit 84b9f99 into IntelPython:master Apr 28, 2023
@antonwolfy antonwolfy deleted the no_vm_mkl_without_fp64 branch April 28, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants