Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse dpctl.tensor.where for dpnp.where #1380

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Reuse dpctl.tensor.where for dpnp.where #1380

merged 4 commits into from
Jun 1, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR modifies dpnp.where() implementation to use dpctl.tensor.where() and remove dpnp_where_c

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Apr 17, 2023
antonwolfy
antonwolfy approved these changes Apr 17, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_algo_searching.pxi Outdated Show resolved Hide resolved
@antonwolfy antonwolfy merged commit b69ab1e into IntelPython:master Jun 1, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the reuse_dpctl_where branch August 10, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy