Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interoperability between SyclDevice and DLPack devices #1953

Merged
merged 13 commits into from
Jan 15, 2025
Merged

Improve interoperability between SyclDevice and DLPack devices #1953

merged 13 commits into from
Jan 15, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jan 4, 2025 •
edited
Loading

This PR proposes improving dpctl's interoperability with DLPack by

  • Adding a new method get_device_id to dpctl.SyclDevice which returns the ordinal ID of a root device
  • Adding new functions dpctl.tensor.dldevice_to_sycldevice and its converse dpctl.tensor.sycldevice_to_dldevice which function as conversions between dpctl.SyclDevices and the DLPack device tuples returned by arr.__dlpack_device__() for some array arr from an arbitrary array library

Closes #1929

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jan 4, 2025
View reviewed changes
dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved
dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_368 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch 2 times, most recently from ac69747 to eb7f4fe Compare January 7, 2025 18:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_411 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2025 •
edited
Loading

Coverage Status

coverage: 87.721% (+0.04%) from 87.683%
when pulling b1a5ecd on dlpack-enum-sycl-device-interop
into 25a53f5 on master.

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from eb7f4fe to c529b29 Compare January 7, 2025 22:05
@ndgrigorian ndgrigorian marked this pull request as ready for review January 7, 2025 22:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_413 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_415 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@ndgrigorian
Copy link
Collaborator Author

@icfaust
This PR implements new DLPack functions in line with your request

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from f010c23 to 5d4c8e8 Compare January 13, 2025 09:29
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_436 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 5d4c8e8 to ec6c1d9 Compare January 13, 2025 17:05
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_440 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_441 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 9559620 to b1e8df1 Compare January 14, 2025 00:54
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_440 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@oleksandr-pavlyk
Copy link
Collaborator

The docstring for the newly added method did not render well:

image

The example included in the docstring is missing. I suspect this is due to missing empty lines around :Example:.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_450 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian
Copy link
Collaborator Author

@oleksandr-pavlyk
The documentation rendering issue has been fixed.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_452 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 64687a2 to 7a9c6a8 Compare January 14, 2025 19:31
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_452 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 50a5523 to afce3b3 Compare January 15, 2025 19:03
@ndgrigorian
Add get_device_id method to SyclDevice
6781a82
@ndgrigorian
Adds conversion functions for dldevice and dpctl.SyclDevice
ea6e061
@ndgrigorian
import SyclDevice directly in _dldevice_conversions
d972d07 
Full dpctl namespace is unnecessary, as only SyclDevice is used
@ndgrigorian
Add tests for dldevice and sycldevice interchange functions
2583383
@ndgrigorian
Add tests for dpctl.SyclDevice.get_device_id method
7d35624
@ndgrigorian
use sycl_device instead of sycldevice in dldevice conversion functions
f15778e
@ndgrigorian
Change errors throughout _sycl_device.pyx
14c7dc5
@ndgrigorian
Add docstring for dpctl.SyclDevice.get_device_id
55944bc
@ndgrigorian
Fix incorrect SyclDevice docstring
d3058ac
@ndgrigorian
Fix missing line breaks in get_device_id method
d5cbe3f
@ndgrigorian
Fix get_device_id example spacing
66d8025
@ndgrigorian
Adds get_unpartitioned_parent_device method to SyclDevice
cda903b
@ndgrigorian
Use get_device_id to find DLpack device ID
b1a5ecd
@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from afce3b3 to b1a5ecd Compare January 15, 2025 19:34
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_460 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_462 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

1 similar comment
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_462 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, @ndgrigorian

Sorry it took a few iterations, but it all looks good now, and we caught few legacy issues too.

@ndgrigorian ndgrigorian merged commit a86da4b into master Jan 15, 2025
62 checks passed
@ndgrigorian ndgrigorian deleted the dlpack-enum-sycl-device-interop branch January 15, 2025 23:32
@ndgrigorian
Copy link
Collaborator Author

Thank you for working on this, @ndgrigorian

Sorry it took a few iterations, but it all looks good now, and we caught few legacy issues too.

Yes, and it cleans up the DLPack code quite nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: create SyclDevice and attribute to and from dlpack Enum in Python
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk