Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Save repeated expression in accumulation functor operator to a variable #1896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Checking in small change in accumulator header file.

It saved repeated sub-expressions into a temporary to clean up the code and hopefully reduce the size of the binary by a few bytes.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk changed the title Save repeated expression in accumulation functor operator to a variable [MAINT] Save repeated expression in accumulation functor operator to a variable Nov 15, 2024
Copy link

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_206 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.705%. remained the same
when pulling 1db958a on accumulator-maint-tweak
into dd2812f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants