Elementwise functions tuning #1889
Open
+2,597
−588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
reviewed
Nov 12, 2024
dpctl/tensor/libtensor/include/kernels/elementwise_functions/vec_size_util.hpp
Outdated
Show resolved
Hide resolved
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1889/index.html |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_202 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_203 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_209 ran successfully. |
oleksandr-pavlyk
force-pushed
the
elementwise-functions-tuning
branch
from
ae56e7b
to
4c0de00
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_204 ran successfully. |
Use sg.get_max_local_range instead. The `sg.get_local_range` must perform lots of checks to determine if this is the last trailing sub-group in the work-group and its actual size may be smaller. We set the local work-group size to be 128, which is a multiple of any sub-group size, and hence get_local_range() always equals to get_max_local_raneg(). The size of the work-groups was increated from 128 to 256, which is chosen so that all 8 threads of single vector with simd32 are used. Set vec_sz and n_vecs in implementations of contig_impl for each support function Make local work-groups size dependent on number of elements to process Fixes for type dispatching utils 1. Add missing include <type_traits> needed for std::true_type, and std::disjunction, std::conjunction 2. Replace std::bool_constant<std::same_v<T1, T2>> with direct and simpler std::same<T1, T2> in couple of instances Hide hyperparameter selection struct in anonymous namespace
vec operator should also apply isnan for sycl::half
oleksandr-pavlyk
force-pushed
the
elementwise-functions-tuning
branch
from
4c0de00
to
70a0a3f
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_226 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revisits elementwise functions functors for contiguous inputs.
Since work-group size is chose so that it is always a multiple of any permissible sub-group size, there is no point in using more expensive
sg.get_local_range(), so it is replaced with cheapersg.get_max_local_range(). This change also slightly reduces the binary size due to leaner kernel (from36428264bytes down to36345112bytes).Implementations of each elementwise function for contiguous input can now set hyperparameters
vec_szandn_vecsdifferently for different input types. This ability is applied toadd_contig_implfor some modest performance improvement forint32_t,uint32_t,int64_t,uint64_t,floatanddouble.Fixed missing check in implementation of
minimumandmaximumforsycl::halftype for vector inputs, which caused test failures on AMD CPUs in CI during earlier iterations of this work (Subgroup load store cleanup #1879).Added missing
include <type_traits>in type dispatching headers, and simplified code.