Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sycl::vec overloads for elementwise functions #1223

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

sycl::vec overloads for elementwise functions #1223

wants to merge 3 commits into from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jun 1, 2023 •
edited
Loading

This PR adds overloads for sycl::vec input to the implementations of dpctl.tensor.abs, dpctl.tensor.cos, dpctl.tensor.expm1, dpctl.tensor.log, dpctl.tensor.log1p, and dpctl.tensor.sqrt.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1223/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jun 1, 2023 •
edited
Loading

Coverage Status

coverage: 85.942%. remained the same
when pulling 67bde59 on elementwise-func-fixes
into 5ec9fd5 on master.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_9 ran successfully.
Passed: 259
Failed: 741
Skipped: 116

@oleksandr-pavlyk
Copy link
Collaborator

@ndgrigorian Please check that enabling vec brings on performance benefits on Max GPU.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_20 ran successfully.
Passed: 320
Failed: 680
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_11 ran successfully.
Passed: 388
Failed: 612
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_10 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_6 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_20 ran successfully.
Passed: 876
Failed: 55
Skipped: 59

@ndgrigorian
Copy link
Collaborator Author

Testing has been performed and little-to-no significant performance gains were found for unary functions using sycl::vec overloads.

TODO: benchmark with sub-group loading disabled as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk will be requested when the pull request is marked ready for review oleksandr-pavlyk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk