Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old, unused files #77

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Remove old, unused files #77

merged 2 commits into from
Jan 31, 2019

Conversation

luisremis
Copy link
Contributor

No description provided.

@luisremis luisremis requested a review from vishakha041 January 30, 2019 21:44
@vishakha041
Copy link
Contributor

Does this also remove the folder these files are in? Those were the only two files in that folder

@vishakha041
Copy link
Contributor

There is also still RWLock.h and arch.h files which I think are not needed anymore. YOu can change this one to code cleanup branch and put two commits as far as I can tell right now

vishakha041
vishakha041 suggested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@vishakha041 vishakha041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hte examples folder and add another commit to remove RWLock + arch.h in src/. I didn't see other unnecessary stuff lying around but worth a quick scan

@luisremis luisremis changed the title Remove old, outdated examples Remove old, unused files Jan 30, 2019
@luisremis
Copy link
Contributor Author

Good suggestion. I removed those files as well.

@luisremis
Copy link
Contributor Author

Does this also remove the folder these files are in? Those were the only two files in that folder

Yes, it does.

@luisremis luisremis merged commit 3fc9140 into develop Jan 31, 2019
@luisremis luisremis deleted the remove_old_examples branch January 31, 2019 04:18
cwlacewe added a commit to cwlacewe/vdms that referenced this pull request Apr 14, 2023
@cwlacewe
Add python coverage to workflow and protobuf code for python client (I…
0321712 
…ntelLabs#77)

* Generate buffer code for python client, update coverage workflow to include python code
* Skip failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishakha041 vishakha041 vishakha041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisremis @vishakha041