Add FindFrames command #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at this once we close the other PR. I believe this is based off of that one. |
|
@vishakha041, these are independent, as you can see following the commits. So you can go ahead and review it. |
vishakha041
previously requested changes
Jun 28, 2019
luisremis
force-pushed
the
find_frame
branch
3 times, most recently
from
ffc3f81 to
694e7ef
Compare
|
All comments addressed. Good to go for me! |
|
I've just did an interactive rebase on all three patches to sign them off. All the changes look good to me. |
…ublic Signed-off-by: mahircg <[email protected]>
Signed-off-by: mahircg <[email protected]>
Signed-off-by: mahircg <[email protected]>
|
Created a separate commit for fixing a bug in Video command response. Should be good to go. |
luisremis
approved these changes
Jul 9, 2019
vishakha041
reviewed
Jul 9, 2019
vishakha041
reviewed
Jul 9, 2019
vishakha041
reviewed
Jul 9, 2019
vishakha041
approved these changes
Jul 9, 2019
cwlacewe
added a commit
to cwlacewe/vdms
that referenced
this pull request
Apr 14, 2023
* Fix CIDs 3428250, 3399517, 3399721 * Fix CID 3399499 * Fix CIDs 3399722 and 3399506 * Fix CID 3399609 and 3399442 * Fix CID 3399441 * Fix 3399465 and 3399606 * fix 3399466 * Fix CID 3399404 and 3399679 * Fix CID 3441993 Signed-off-by: tmcourie <[email protected]> Co-authored-by: tmcourie <[email protected]> Co-authored-by: Ragaad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces 'FindFrames' command, that searches for the given
video name and returns a list of frames from the video if it is found.
Currently, FindFrame command relies on OpenCV's frame iteration
capabilities. Thus, the entire video is loaded into memory to be
decoded. In future, the video loading and decoding should be done only
on the requested frame interval.
Signed-off-by: mahircg [email protected]