Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindImage with blob=False crashes server #90

Closed
prashastk opened this issue Mar 15, 2019 · 2 comments
Closed

FindImage with blob=False crashes server #90

prashastk opened this issue Mar 15, 2019 · 2 comments
Assignees
Labels
Bug Indicates unexpected or undesired behaviors Priority: Urgent high priority fixes and/or features.

Comments

@prashastk
Copy link

FindImage with blob=False crashes server

Server error:

"vdms: src/ImageCommand.cc:238: virtual Json::Value VDMS::FindImage::construct_responses(Json::Value&, const Json::Value&, VDMS::protobufs::queryMessage&, const string&): Assertion `findImage.isMember(""entities"")' failed.
/start.sh: line 5:    13 Aborted                 (core dumped) ./vdms
@luisremis luisremis self-assigned this Mar 18, 2019
@luisremis luisremis added Bug Indicates unexpected or undesired behaviors Priority: Urgent high priority fixes and/or features. labels Mar 18, 2019
@luisremis
Copy link
Contributor

luisremis commented Mar 29, 2019

Thanks for pointing this out!
I have just created a PR to fix this.

One note. The following findImage command will still display an error:

{
    'FindImage': {
           'constraints': { // whatever contraints }, 
           'results': { 'blob': False } // without list
     }
}

This is becase no _ref or list in result is specified when blob=false. If blob=false, at least one of { _ref, list in results} must be specified for the query to be valid. If blob=false and neither _ref or list in results is specified, the query is essentially returning nothing (no properties of the image, no blob, not being referred later). VDMS will return an error in this case.

@prashastk
Copy link
Author

There are other result parameters that can still be used other than list. Things like count, sum or average should also work.

Other than that, this sounds good to me.

luisremis added a commit that referenced this issue Apr 1, 2019
cwlacewe added a commit to cwlacewe/vdms that referenced this issue Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indicates unexpected or undesired behaviors Priority: Urgent high priority fixes and/or features.
Projects
None yet
Development

No branches or pull requests

2 participants