Skip to content

Commit

Permalink
Automated updates: Format and/or coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
sys-vdms committed Dec 4, 2024
1 parent 308723d commit e39e0b6
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .github/coverage/cpp.develop.coverage_report.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ src/vcl/CustomVCL.cc 51 22 43% 55,57-58,60-63
src/vcl/DescriptorSet.cc 209 155 74% 65,69-70,93-94,115-116,133,135,137,190-193,196,221-222,224-225,228-231,240-244,256,268,319-320,323,325-328,331,345-346,348-350,354-356,358,365-367,369-370,373-374
src/vcl/DescriptorSetData.cc 55 47 85% 48,58,64,67,114,116-118
src/vcl/Exception.cc 7 6 85% 38
src/vcl/FaissDescriptorSet.cc 206 177 85% 83,115-116,132,167,187-188,204-205,224-225,238-239,245,258-259,261,272-273,279,303-304,306-307,309,372-373,379,397
src/vcl/FaissDescriptorSet.cc 209 177 84% 83,115-116,132,167,187-188,204-205,224-225,238-239,245,258-259,261,272-273,279,303-304,306-307,309,372-373,379,394-396,400
src/vcl/FlinngDescriptorSet.cc 149 109 73% 60-66,89,109-111,113-114,118-121,124,126,128,130,132,134-137,140-141,143-144,170-171,176-177,182,206,208,228,248,279
src/vcl/Image.cc 910 689 75% 62,73-74,76-78,81-84,86,92,101,122-123,125,132-133,135,147,165,170,193,196-199,223,246,249-252,264,273,276-279,291,323,326-329,341,347,349-352,360-362,369,393-396,415,417,425,427,432,436,441,445,459,462,467-468,471-472,474,490,500,513,531,553-556,594,605-606,608,615,619,624,627-630,658-660,712,757-758,809,838-842,844-850,852,854-855,896,899-900,939-940,944-945,966,985-986,988,1028-1030,1032-1036,1038-1042,1044-1048,1050-1054,1056-1060,1062-1065,1088,1109,1128-1136,1147-1148,1167-1186,1198-1199,1207,1218,1220-1222,1224-1226,1228,1242,1246-1247,1249,1254-1255,1257,1278,1282,1285,1292,1307,1313,1322,1336,1361,1379,1462,1481
src/vcl/KeyFrame.cc 303 244 80% 58,62,86,90,95,97,102,105-107,109-111,113,119,139,148,154,172,186,190,216,220,224,235,239,249,255,274,284,288,307,315,341,345,347,359,367,369,394,396,405,430,442,449,465,469,478,483,495,500,507,514,518,525,541,547,557,563
Expand All @@ -57,5 +57,5 @@ utils/src/comm/Exception.cc 6 0 0% 35-40
utils/src/stats/SystemStats.cc 250 249 99% 453
utils/src/timers/TimerMap.cc 82 75 91% 126,151,153,155-158
------------------------------------------------------------------------------
TOTAL 10243 6572 64%
TOTAL 10246 6572 64%
------------------------------------------------------------------------------
2 changes: 1 addition & 1 deletion .github/coverage/cpp.develop.coverage_value.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
64.1609
64.1421
7 changes: 3 additions & 4 deletions tests/unit_tests/DescriptorSetAdd_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -351,11 +351,11 @@ TEST(Descriptors_Add, add_hnswflatip_100d) {
// init.11 init.11 ... init.11 (D times)
// ...
// init.nb-1 init.nb-1 ... init.nb-1 (D times)
// hence, nearest neigbor of any query descriptor are the IDs that is next to
// hence, nearest neigbor of any query descriptor are the IDs that is next to
// the query ID

int d = 100;
int nb = 100; //we are using 2 decimal points for I.P. nb is maximum 100
int nb = 100; // we are using 2 decimal points for I.P. nb is maximum 100
float *xb = generate_desc_inner_product_increase(d, nb);

std::string index_filename = "dbs/add_hnswflatip_100d";
Expand All @@ -382,13 +382,12 @@ TEST(Descriptors_Add, add_hnswflatip_100d) {
for (int i = 0; i < distances.size() - 1; ++i) {
EXPECT_LT(distances[i], distances[i + 1]);
}

index.store();

delete[] xb;
}


// Flinng Tests

TEST(Descriptors_Add, add_flinngIP_100d) {
Expand Down
33 changes: 17 additions & 16 deletions tests/unit_tests/helpers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -213,21 +213,22 @@ float *generate_desc_linear_increase(int d, int nb, float init) {
return xb;
}

//Functions to generate descriptors close in inner product metric
//for example for d=3, nb=5 and init=1.0f
//the generated vectors will be
// Vector 0: [1.00, 1.00, 1.00]
// Vector 1: [1.11, 1.11, 1.11]
// Vector 2: [1.23, 1.23, 1.23]
// Vector 3: [1.36, 1.36, 1.36]
// Vector 4: [1.50, 1.50, 1.50]
// in the IP domain, closest vector to descriptor K is (K+1)

void generate_desc_inner_product_increase(int d, int nb, float *xb, float init) {
// Functions to generate descriptors close in inner product metric
// for example for d=3, nb=5 and init=1.0f
// the generated vectors will be
// Vector 0: [1.00, 1.00, 1.00]
// Vector 1: [1.11, 1.11, 1.11]
// Vector 2: [1.23, 1.23, 1.23]
// Vector 3: [1.36, 1.36, 1.36]
// Vector 4: [1.50, 1.50, 1.50]
// in the IP domain, closest vector to descriptor K is (K+1)

void generate_desc_inner_product_increase(int d, int nb, float *xb,
float init) {
float val = init;
for (int i = 0; i < nb; ++i) {
for (int j = 0; j < d; ++j) {
xb[i * d + j] = val;
xb[i * d + j] = val;
}
val += 0.1f + (i * 0.01f); // Increase increment as index increases
}
Expand All @@ -239,10 +240,10 @@ float *generate_desc_inner_product_increase(int d, int nb, float init) {
return xb;
}

//Functions to create a distribution of descriptors
// resulting descriptors are clustered around cluster heads
// nearest neighbors when the cluster head is used for query should be
// the remaining descriptors within the cluster (with no strict order)
// Functions to create a distribution of descriptors
// resulting descriptors are clustered around cluster heads
// nearest neighbors when the cluster head is used for query should be
// the remaining descriptors within the cluster (with no strict order)
void generate_desc_normal_cluster(int d, int nb, float *xb, float init,
int cluster_size, float clusterhead_std,
float cluster_std) {
Expand Down
3 changes: 2 additions & 1 deletion tests/unit_tests/helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ void generate_desc_linear_increase(int d, int nb, float *xb, float init = 0);

float *generate_desc_linear_increase(int d, int nb, float init = 0);

void generate_desc_inner_product_increase(int d, int nb, float *xb, float init = 1.0);
void generate_desc_inner_product_increase(int d, int nb, float *xb,
float init = 1.0);

float *generate_desc_inner_product_increase(int d, int nb, float init = 1.0);

Expand Down

0 comments on commit e39e0b6

Please sign in to comment.