This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Copy, Rename and delete FileAction #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qiyuangong
commented
Jul 25, 2017
qiyuangong
commented
- CopyFileAction
- RenameFileAction
- DeleteFileAction
* Modify ReadAction * CopyFileAction basic. * Finish single file copy. * Rename constant values.
Modify DeleteFileAction. Add RenameFileAction and DeleteFileAction to HdfsActionFactory.
littlezhou
reviewed
Jul 25, 2017
| Configuration conf = new Configuration(); | ||
| //get FileSystem object | ||
| FileSystem fs = FileSystem.get(URI.create(filePath), conf); | ||
| if (!fs.exists(new Path(filePath))){ |
littlezhou
reviewed
Jul 25, 2017
| } | ||
| appendLog( | ||
| String.format("Action starts at %s : Read %s", Utils.getFormatedCurrentTime(), srcPath)); | ||
| if (!dfsClient.exists(srcPath)) { |
There was a problem hiding this comment.
Better to check the existence of dstPath too.
There was a problem hiding this comment.
Need more parameters from configuration/map. Will be done later.
littlezhou
reviewed
Jul 25, 2017
| //get FileSystem object | ||
| FileSystem fs = FileSystem.get(URI.create(dest), conf); | ||
| return fs.rename(new Path(src), new Path(dest)); | ||
| } else if (!dest.startsWith("hdfs") && !src.startsWith("hdfs")) { |
There was a problem hiding this comment.
what about the following case: dest prefixed with the default hdfs uri while src not, the two path are in the same cluster
There was a problem hiding this comment.
That should be done after url handler is finished.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.