This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Fix #2017, support debug mode for master server, standby server, agent #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
reviewed
Nov 29, 2018
bin/start-ssm.sh
Outdated
| @@ -93,7 +99,8 @@ if [ x"${SMARTSERVERS}" != x"" ]; then | |||
| --config "${SMART_CONF_DIR}" \ | |||
| --hosts "${OTHER_MASTERS}" --hostsend \ | |||
| --daemon start \ | |||
| smartserver $SMART_VARGS_STANDBY | |||
| smartserver $ | |||
| SMART_VARGS_STANDBY | |||
There was a problem hiding this comment.
It seems that there is no need to put SMART_VARGS_STANDY on a new line.
bin/start-agent.sh
Outdated
| @@ -24,6 +24,7 @@ bin=$(cd "${bin}">/dev/null; pwd) | |||
|
|
|||
| AGENT_HOSTS= | |||
| while [ $# != 0 ]; do | |||
| DEBUG_OPT="" | |||
There was a problem hiding this comment.
Move this statement to the outside of while loop. Please test again after that.
PHILO-HE
changed the title
added 2 commits
November 30, 2018 13:50
|
Please update "Run SSM" section in ssm-deployment-guide.md for introducing SSM's debug mode for three processes. |
PHILO-HE
pushed a commit
that referenced
this pull request
Dec 19, 2018
PHILO-HE
pushed a commit
that referenced
this pull request
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.