make ewext compileable on old systems UPD: added as feature flag #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
isn't this something we should never push? if its not fixed in master its probably more complicated |
Yes, hence draft pull request. I could make it a separate feature that is toggled via flag while compiling, so that there is possibility to use this patch, but it would not interfere with anything else. If you guys cool with that, i will update this branch & PR with new commit that does that. |
kcalbxof
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see rust-lang/rust#79609
This patch does make compilation of ewext work on Ubuntu 20.04 with old mingw version, but IT WILL BREAK current CI/CD workflow due to multiple definitions of _Unwind_Resume (understandably so). I am in no way the rust guru, so i though maybe you guys could do something with it, since it will be useful in a long run.