Fix a monolog call that masked underlying exceptions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DNS resolution failed we logged a message. Unfortunately the logger call had an incorrect argument and would then raise a new exception. This removes the bad argument and adds a test to verify the correct message gets logged. #3
This removes code that we had to hide errors from printing to the screen as well as updating the connection test to check for the appropriate error message.
mediocretes
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DNS resolution failed we logged a message. Unfortunately the
logger call had an incorrect argument and would then raise a new
exception.
This removes the bad argument and adds a test to verify the correct
message gets logged.
#3