-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1810 fix #1825
Merged
Merged
1810 fix #1825
Changes from 1 commit
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
c6aba65
Better logging
devclinton 42d3893
Added back changes made to 1810 original branch
emilydriano b9745a9
Make test platform compatible with id generators
devclinton a1ae14c
updated platform in test_item_sequence to 'Test' and added tests base…
emilydriano 0908d9d
* Fix name of dummy suite method
devclinton ea96c12
Merge remote-tracking branch 'origin/1810-fix' into 1810-fix
devclinton d2925c5
* Add configuration caching to item sequence
devclinton 33b50ef
Add cache clearing to tests
devclinton 073df66
Fix tests
devclinton e3ac2b6
Update slurm tests to be UUID agnostic
devclinton cee87fd
Make test valid
devclinton c0f6eed
Mark test serial to prevent being ran with other tests because of con…
devclinton 6b8ee82
Rest id on close
devclinton 269f789
Updated documentation for item_sequence plugin, cleaned up test_item_…
emilydriano c12b778
Added methods to clear configuration before persistence_services and …
emilydriano ce414fa
Added documentation for new functions related to id generation.
emilydriano 7d42595
Change order to ensure file is locked during write
devclinton 05b6b6d
Add file locking
devclinton ea70b0b
Relay error if it occurs too much
devclinton c62bad8
Update tests
devclinton 8000098
* Fix locking on item sequence
devclinton b20fef3
* Update performance test to add asserts
devclinton 9b2451b
Update nechmark
devclinton 200d457
* Fix linting
devclinton b2ad98e
* Replace with lru cache to be work with 3.7
devclinton 68c0408
Clear other cache
devclinton 20d67a5
Merge branch 'dev' into 1810-fix
devclinton 7bbccf6
#1930 - New hook spec
devclinton 86362ca
Merge remote-tracking branch 'origin/dev' into 1810-fix
devclinton fda3fdf
* Fix uid issue
devclinton a23b40c
* Document uid copy for manual case
devclinton 21ea7c3
Updated default item sequence file to be $HOME/.idmtools/item_sequenc…
emilydriano 40a8c0d
Merge branch '1810-fix' of https://github.com/InstituteforDiseaseMode…
emilydriano b756f8c
Updated item sequence file load Json error, & added logic to idmtools…
emilydriano bb621c3
Created test to verify existence and correctness of .bak file (backup…
emilydriano 813af5d
* #1936 - Add constant for IDMTOOLS home path
devclinton 585ac18
* Add post create hook at all different types of objects
devclinton 5f1972a
Fix commit issue
devclinton 118a3d5
* Fix linting
devclinton 92d5059
# 1938 - Add post run hook
devclinton 41650a0
Updated item_sequence plugin from post_create_item to post_run
emilydriano a0b4e64
Added logic to make slurm fail if directory exists
emilydriano c238580
Removed duplicate creation of simulation items in test_item_sequence
emilydriano 0a9997d
Updated item_sequence documentation
emilydriano 4d7a49c
- corrected logic to allow user to override exist_ok directory option…
emilydriano 61441a0
Expanded on item_sequence plugin documentation.
emilydriano 53f33eb
added 'performance' pytest mark, applied to test_id_generation
emilydriano 9935564
https://github.com/InstituteforDiseaseModeling/idmtools/issues/1954
devclinton 80a180d
#1954 - Move to strings for ids within core
devclinton e911817
#1954 - implementation of using str, not uuid
emilydriano 758855d
#1954 - implementation of using str, not uuid
emilydriano 86f05ef
#1954 - restored line in slurm item operations to set uid when conver…
emilydriano ea79ee0
#1954 - restored line in analyze_manager.py
emilydriano 74d4eee
Merge branch 'dev' into 1810-fix
emilydriano 6efc658
removed redundant Union expressions
emilydriano 611b5f6
fixed linting issues
emilydriano 28cb52f
changed UUID to str in slurm create_sim_dir_map functions
emilydriano 032cdfc
final UUID > str changes, updated sequential_id_example
emilydriano 414524d
excluded performance tests from test-all and test-smoke
emilydriano 1b535d0
added jinja2 (used in item_sequence plugin) to requirements.txt files
emilydriano 4dc93f1
updated pytest-html to 3.1.1
emilydriano 948b128
Including target dir in error message to specify which dir already ex…
emilydriano 197e012
modified experiment result to avoid causing the sims to be iterated u…
emilydriano 71f732a
modified experiment result to avoid causing the sims to be iterated u…
emilydriano d338808
modified tests to exclude slurm experiment simulation data
emilydriano 1e90f8b
modified create_sim_dir_map test to account for metadata change
emilydriano 600f084
Merge branch 'dev' into 1810-fix
emilydriano 5fdc8b0
changed named 'slurm_experiment' to 'experiment' in test_create_sim_d…
emilydriano 56f26d7
Merge branch '1810-fix' of https://github.com/InstituteforDiseaseMode…
emilydriano a3899a3
used experiment post create in test execute platform to save simulati…
emilydriano 6b89439
included missing package
emilydriano 8e81982
added backup sequence file process to post-run hook for test-execute …
emilydriano e3ec545
Merge branch 'dev' into 1810-fix
emilydriano 965a7e6
simplified code with super function
emilydriano ea7ba8c
added kwargs to post_run_item call
emilydriano 99463d3
Merge branch 'dev' into 1810-fix
emilydriano 14e6c2f
Update item_sequence.py
devclinton 6b9a9aa
Update item_sequence.py
shchen-idmod 32ffb5f
added changes defining 'meta' var in idmtools_platform_slurm platform…
emilydriano 557b1fe
Merge remote-tracking branch 'origin/1810-fix' into 1810-fix
emilydriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the almost exactly what super class function of post_run_item does (still missing experiment.post_run(self.platform). so no need to copy code. just need call super function.