Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for running libcst using a python 3.6 interpreter #663

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

lpetre
Copy link
Contributor

@lpetre lpetre commented Mar 23, 2022

Summary

Python 3.6 security support ended in December 2021. Some major libraries (including some transitive dependencies) have stopped supporting 3.6.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2022
@lpetre lpetre requested a review from zsol March 23, 2022 17:39
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme needs some changing too

setup.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #663 (2a95270) into main (f863feb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   94.79%   94.81%   +0.01%     
==========================================
  Files         249      249              
  Lines       25456    25448       -8     
==========================================
- Hits        24132    24128       -4     
+ Misses       1324     1320       -4     
Impacted Files Coverage Δ
setup.py 88.88% <ø> (ø)
libcst/_type_enforce.py 93.54% <100.00%> (+4.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f863feb...2a95270. Read the comment docs.

@lpetre lpetre requested a review from zsol March 23, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants