Apply Type Comments: Allow for skipping quotes when applying type comments #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
stroxler
changed the title
Codecov Report
@@ Coverage Diff @@
## main #644 +/- ##
==========================================
- Coverage 94.79% 94.78% -0.01%
==========================================
Files 245 245
Lines 25289 25304 +15
==========================================
+ Hits 23973 23985 +12
- Misses 1316 1319 +3
Continue to review full report at Codecov.
|
zsol
approved these changes
Feb 10, 2022
| @@ -388,7 +412,7 @@ class ConvertTypeComments(VisitorBasedCodemodCommand): | |||
| - For parameters, we prefer inline type comments to | |||
| function-level type comments if we find both. | |||
|
|
|||
| We always apply the type comments as quoted annotations, unless | |||
| We always apply the type comments as quote_annotations annotations, unless | |||
There was a problem hiding this comment.
I think this one is intended - in the docstring I do want to talk about "quoted annotations" when discussing the impact of the flag on output, quote_annotations is just the name of the python variable.
1 task
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The motivation for this is pytorch, where type comments mostly are maintained and it is
better to avoid quotes in methods that have jit compiler decorators.
Test Plan
I added a new test case verifying that the flag is properly propagated for all node types
that we would transform. Tests pass.