Autoformat ApplyTypeAnnotationsVisitor #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it difficult sometimes to read method and function signatures when there are multiple arguments with type annotations - left-aligning the arguments makes it much easier for me to skim and see, using mostly my automatic visual resoning, - the argument names - the argument types - the return type Without this, I feel like I'm trying to run a parser in my head, which is not as fast and distracts me from code-skimming. This change was generated using thte new AddTrailingCommas codemod (which I'll put in a separate PR) via the command ``` python -m libcst.tool codemod add_trailing_commas.AddTrailingCommas ./libcst/codemod/visitors/_apply_type_annotations.py ``` Wait for CI - this is pure formatting, it should be very safe
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 245 245
Lines 25289 25289
=======================================
Hits 23973 23973
Misses 1316 1316
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I find it difficult sometimes to read method and function signatures
when there are multiple arguments with type annotations - left-aligning
the arguments makes it much easier for me to skim and see, using mostly
my automatic visual resoning,
Without this, I feel like I'm trying to run a parser in my head, which
is not as fast and distracts me from code-skimming.
This change was generated using thte new AddTrailingCommas codemod
(see #643) via the command
Test Plan
Wait for CI - this is pure formatting, a format-only change should be very safe