Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix copyright headers and add a script to check #635

Merged
merged 2 commits into from
Feb 1, 2022
Merged

fix copyright headers and add a script to check #635

merged 2 commits into from
Feb 1, 2022

Conversation

zsol
Copy link
Member

@zsol zsol commented Jan 28, 2022

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #635 (78468b5) into main (c5b0735) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         245      245           
  Lines       25281    25281           
=======================================
  Hits        23963    23963           
  Misses       1318     1318
Impacted Files Coverage Δ
libcst/_nodes/tests/test_match.py 100.00% <ø> (ø)
libcst/_parser/parso/python/token.py 19.04% <ø> (ø)
libcst/_parser/py_whitespace_parser.py 95.68% <ø> (ø)
libcst/_parser/types/py_config.py 100.00% <ø> (ø)
libcst/_parser/types/py_token.py 100.00% <ø> (ø)
libcst/_parser/types/py_whitespace_state.py 100.00% <ø> (ø)
libcst/codemod/visitors/_apply_type_annotations.py 95.18% <ø> (ø)
...emod/visitors/tests/test_apply_type_annotations.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b0735...78468b5. Read the comment docs.

thatch
thatch reviewed Jan 28, 2022
View reviewed changes
check_copyright.sh
error "Missing copyright in $filename"
fi
done < <( git ls-tree -r --name-only HEAD | grep "\(.py\|\.sh\|\.rs\)$" | grep -v "${EXCEPTION_PATTERNS[@]/#/-e}" )
exit $EXITCODE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newline would be nice

thatch
thatch approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@thatch thatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice script!

@zsol zsol merged commit c91655f into Instagram:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatch thatch thatch approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsol @codecov-commenter @thatch @facebook-github-bot