Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Fix imjoy_jupyterlab_extension module detection #689

Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Nov 14, 2023

With the bump to 0.1.20, the module name changed to:

imjoy_jupyterlab_extension

from:

imjoy-jupyterlab-extension

With the bump to 0.1.20, the module name changed to:

  imjoy_jupyterlab_extension

from:

  imjoy-jupyterlab-extension
@thewtex thewtex requested review from bnmajor and oeway November 14, 2023 13:55
@thewtex
Copy link
Member Author

thewtex commented Nov 14, 2023

@oeway for Jupyter Notebook 7, will we only need imjoy-jupyerlab-extension?

Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@thewtex thewtex merged commit 7527746 into InsightSoftwareConsortium:main Nov 14, 2023
5 checks passed
@thewtex thewtex deleted the imjoy-jupyerlab-import-name branch November 14, 2023 16:44
@oeway
Copy link
Collaborator

oeway commented Nov 14, 2023

@oeway for Jupyter Notebook 7, will we only need imjoy-jupyerlab-extension?

Not sure, I only did the upgrade using the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants