Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngff follow ups #544

Merged
merged 4 commits into from
Oct 5, 2022
Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Oct 4, 2022

No description provided.

@thewtex thewtex requested a review from bnmajor October 4, 2022 21:57
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bnmajor
Copy link
Collaborator

bnmajor commented Oct 5, 2022

@thewtex When I try to run either the 3DImage or DaskArray notebooks I get the following error:

Traceback (most recent call last):
  File "/home/local/KHQ/brianna.major/.virtualenvs/clean-itkwidgets/lib/python3.8/site-packages/imjoy_rpc/rpc.py", line 404, in _wait
    result = await result
  File "/home/local/KHQ/brianna.major/itkwidgets/itkwidgets/viewer.py", line 87, in run
    result = _get_viewer_image(data, label=False)
  File "/home/local/KHQ/brianna.major/itkwidgets/itkwidgets/integrations/__init__.py", line 83, in _get_viewer_image
    multiscales = to_multiscales(ngff_image, method=method)
  File "/home/local/KHQ/brianna.major/.virtualenvs/clean-itkwidgets/lib/python3.8/site-packages/ngff_zarr/to_multiscales.py", line 109, in to_multiscales
    images = _downsample_dask_image(
  File "/home/local/KHQ/brianna.major/.virtualenvs/clean-itkwidgets/lib/python3.8/site-packages/ngff_zarr/methods/_dask_image.py", line 110, in _downsample_dask_image
    previous_image = _align_chunks(previous_image, default_chunks, dim_factors)
  File "/home/local/KHQ/brianna.major/.virtualenvs/clean-itkwidgets/lib/python3.8/site-packages/ngff_zarr/methods/_support.py", line 27, in _align_chunks
    previous_image.data = previous_image.data.chunk(aligned_chunks)
AttributeError: 'Array' object has no attribute 'chunk'

Edit: Just noting that this happens in transform_visualization and vtkImageData as well.

@thewtex
Copy link
Member Author

thewtex commented Oct 5, 2022

@bnmajor thanks for testing, addressed in ebfcd8e

Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking great!

@thewtex thewtex merged commit e7d8f71 into InsightSoftwareConsortium:main Oct 5, 2022
@thewtex thewtex deleted the ngff-follow-ups branch October 5, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants