Agave renderer #61
Agave renderer #61
Conversation
thewtex
force-pushed
the
agave-renderer
branch
from
b21a91a to
d335fd5
Compare
| @@ -8,6 +8,7 @@ | |||
| "dev": "pnpm -r --parallel run dev", | |||
| "build": "pnpm -r build", | |||
| "lint": "pnpm prettier --check . && pnpm eslint .", | |||
| "lint:fix": "pnpm prettier --write . && pnpm eslint --fix .", | |||
| case UnknownEventAction.IGNORE: | ||
| pass | ||
|
|
||
| async def start_renderer(self, hypha_server_url, load_image_into_agave_fn, visibility="public"): |
There was a problem hiding this comment.
I see this is moved in as a class function. Kind of liked it as a top level factory func, but no biggie.
There was a problem hiding this comment.
Yes, I can see it both ways, but since it references self quite a bit, I made it a method.
I am renaming it to connect, but suggestions are welcome on the naming.
|
|
||
| await server.register_service({ | ||
| "name": "Agave Renderer", | ||
| "id": "agave-renderer", |
There was a problem hiding this comment.
Bumping the id seemed to solve some of my connection problems, some of the time. Making this as configurable as hypha_server_url might be convenent.
|
|
||
| "setup": self.setup, | ||
|
|
||
| "loadImage": functools.partial(load_image_into_agave_fn, renderer), |
There was a problem hiding this comment.
renderer is coming from self.renderer as a class function now I suppose.
Yes, great idea. Let's do it after we have another renderer implementation. Tracked: |
No description provided.