-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Refactor itk-dreg abstract interface for plugin methods #2
ENH: Refactor itk-dreg abstract interface for plugin methods #2
Conversation
Feedback from DRMNI discussion:
|
Addressed feedback from today:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
6808dc1
to
54056f7
Compare
@thewtex ping for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving it! 😍
f45575b
to
438718f
Compare
Squashed changes EDIT: Also corrected the |
Refactors the proposed `itk-dreg` platform interface to better support extended registration methods within a `dask`-based framework: - Moves interfaces into `import`-able `itk_dreg` Python module - Restructures base types and abstract methods - Introduces helper types for working with dask blocks with metadata - Proposes updates to "register` interface for block-based registration - Proposes abstract interfaces for ITK image stream reader construction and block registration postprocessing.
Add simple `pytest` infrastructure to validate that `itk_dreg` module scripts load without error.
438718f
to
523293f
Compare
Proposal to refactor the
itk-dreg
platform interface to better supportextended registration methods within a
dask
-based framework:import
-ableitk_dreg
Python moduleand block registration postprocessing.
Discussion and feedback are welcome.