Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump ITK to v5.3rc04.post1 #57

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Jul 13, 2022

Bump ITK to v5.3rc04 (C++ tag) and v5.3rc04 (Python tag).

Will use this PR to ensure bump goes smoothly before moving on to other external modules.

@tbirdso tbirdso requested review from thewtex and dzenanz July 13, 2022 12:50
@tbirdso
Copy link
Contributor Author

tbirdso commented Jul 13, 2022

Linux Python failure:

Status: Downloaded newer image for dockcross/manylinux_2_28-x64:20220705-b1eb184
Error: dockcross/manylinux_2_28-x64:latest: image not known
Error: no container with name or ID "dockcross_25364" found: no such container

@thewtex Any thoughts on this one? Looks like it could be related to InsightSoftwareConsortium/ITKPythonPackage@74561b6, though the build process appears to find and successfully download the updated manylinux image.

@tbirdso
Copy link
Contributor Author

tbirdso commented Jul 13, 2022

Also pinging @jcfr for help as this seems to be related to dockcross image updates in InsightSoftwareConsortium/ITKPythonPackage#193 and possibly dockcross/dockcross@ada2c8d

@thewtex
Copy link
Member

thewtex commented Jul 15, 2022

@tbirdso thanks for working on this.

dockcross/dockcross#715 should address this.

Applied in https://github.com/InsightSoftwareConsortium/ITKPythonPackage and building now so we can test it.

@tbirdso
Copy link
Contributor Author

tbirdso commented Jul 18, 2022

@thewtex It looks like dockcross/dockcross#715 CI is failing, I am guessing that PR is blocking this one?

@thewtex
Copy link
Member

thewtex commented Jul 21, 2022

@tbirdso there is more work to do for the general dockcross use case / ci, but the versioned based image was pushed for testing, working now 🎉

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbirdso thank you!

@thewtex thewtex merged commit d76d3ec into InsightSoftwareConsortium:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants