-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Adjust title of ImageBufferAndIndexRange
example
#386
DOC: Adjust title of ImageBufferAndIndexRange
example
#386
Conversation
Following the guideline on how the write a title, at https://examples.itk.org/documentation/contribute/writeanewexample#title which suggests filling out the dots ("...") of the question, "How do I ...?"
@thewtex @tbirdso Is it OK to you to extend the title to "Iterate Over an Image Buffer and an Index Range", while still keeping the name of the directory and the test project short ( I'm asking specifically because on Windows, long directory path names still appear troublesome, nowadays! So I'm reluctant to rename the directory to something like "IterateOverAnImageBufferAndAnIndexRange". Unless you insist 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other examples of larger discrepancy between directory name and example title?
@N-Dekker I agree with the motivation to keep the directory name short if possible. I am not sure if the docs style check will allow an example name that differs from the parent directory. Let's see whether |
FYI, I just figured out (*) that the longest ITKSphinxExamples src directory path name so far is:
So (*) PS I estimated the longest directory path name by the following code: https://godbolt.org/z/hdKneP97P
|
When I tried to build ITKSphinxExamples for the first time (on Windows), I did encounter those CMake errors, even while my local source and build directory path names were rather short, in my opinion (something like "D:\X\source\ITKSphinxExamples" and "D:\X\build\ITKSphinxExamplesSuper"): ITKSphinxExamples/CMakeLists.txt Lines 64 to 75 in 66cbdd6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we may need to diverge on the Windows and example name for path length issues.
@N-Dekker Checks passed, great! Yes, Windows paths are a pain point here, it may be worthwhile for us to revisit and rename example directories with long titles as you found. In CI we use |
Following the guideline on how the write a title, at
https://examples.itk.org/documentation/contribute/writeanewexample#title
which suggests filling out the dots ("...") of the question, "How do I ...?"