Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Revert deploy to Netlify #348

Merged
merged 3 commits into from
May 4, 2022
Merged

BUG: Revert deploy to Netlify #348

merged 3 commits into from
May 4, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented May 2, 2022 •
edited
Loading

Partially addresses #341.

@tbirdso tbirdso requested a review from thewtex May 2, 2022 18:52
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels May 2, 2022
@tbirdso tbirdso mentioned this pull request May 2, 2022
Closed
thewtex
thewtex approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖 🗝️

@tbirdso
Copy link
Contributor Author

tbirdso commented May 2, 2022

I have opened #349 to track the two new test failures in CDash. Failures are unrelated to this change and likely result from a recent-ish change in wrapping for a certain ITK class.

@tbirdso
Copy link
Contributor Author

tbirdso commented May 3, 2022

Bumped ITK version to include resolution for #349 in InsightSoftwareConsortium/ITK#3406

@tbirdso
Copy link
Contributor Author

tbirdso commented May 3, 2022

Looks like Python superbuild tests rely on ITK Python packages, so the fix for #349 will not be included until the next time an ITK Python package is released. I am disabling the offending tests for now and have added a comment to re-enable in the future.

@github-actions github-actions bot added the area:Registration Issues affecting the Registration module label May 3, 2022
@tbirdso
BUG: Revert deploy to Netlify
2d8514b
@tbirdso
ENH: Bump ITK version
50d60aa
@tbirdso
BUG: Disable broken RegisterTwoPointSets tests
9183236 
Broken due to wrapping change in ITK v5.3rc03. Wrapping is restored and
test is expected succeed for ITK packages post v5.3rc04.
@github-actions github-actions bot temporarily deployed to production May 3, 2022 18:31 Inactive
@tbirdso
Copy link
Contributor Author

tbirdso commented May 3, 2022

Looks like auto-deploy is working, examples.itk.org is updated with today's date.

https://examples.itk.org/

@github-actions
Copy link

github-actions bot commented May 3, 2022

🎉 Published on https://examples.itk.org as production
🚀 Deployed on https://6271779583550e0c3b08b52d--itkexamples.netlify.app

thewtex
thewtex approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!!

@thewtex thewtex merged commit b34fcdb into master May 4, 2022
@thewtex thewtex deleted the deploy-netlify branch May 4, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
area:Registration Issues affecting the Registration module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbirdso @thewtex