Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Use https protocol for Superbuild CI #330

Merged
merged 1 commit into from
Mar 16, 2022
Merged

BUG: Use https protocol for Superbuild CI #330

merged 1 commit into from
Mar 16, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Mar 16, 2022

Closes #328

@tbirdso tbirdso requested a review from dzenanz March 16, 2022 14:25
@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 16, 2022

Whoops, thought CI was unchanged from my branch. Closing in favor of #329.

@tbirdso tbirdso closed this Mar 16, 2022
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Mar 16, 2022
@tbirdso tbirdso mentioned this pull request Mar 16, 2022
Closed
@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 16, 2022

Re-opening this branch after observing Github CI issues in #329 trying to reference #330.

@tbirdso tbirdso reopened this Mar 16, 2022
@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 16, 2022

Docs warnings are already tracked in #266 . Proceeding with merge.

@tbirdso tbirdso merged commit 52bbe44 into master Mar 16, 2022
@jhlegarreta jhlegarreta deleted the https-protocol branch March 19, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zlib download fails
2 participants
@tbirdso @dzenanz