Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup sphinx examples #311

Merged
merged 3 commits into from
Dec 27, 2021
Merged

Cleanup sphinx examples #311

merged 3 commits into from
Dec 27, 2021

Conversation

hjmjohnson
Copy link
Member

No description provided.

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Segmentation Issues affecting the Segmentation module language:C++ Changes to C++ examples labels Nov 20, 2021
@hjmjohnson hjmjohnson requested a review from dzenanz November 20, 2021 17:31
@github-actions github-actions bot added area:Bridge Issues affecting the Bridge module area:Registration Issues affecting the Registration module language:Python Changes to Python examples type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Nov 20, 2021
dzenanz
dzenanz reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good cleanup!

src/Core/Transform/GlobalRegistrationTwoImagesBSpline/Code.cxx Show resolved Hide resolved
@hjmjohnson
STYLE: address unused variable warnings.
000ccbc 
Types and variables that were unused were
removed to avoid compiler warnings.
@hjmjohnson
STYLE: Remove outdated pre ITKv4 code
c211f7c 
The examples are easier to interpret when the
very old pre ITKv4 code is removed.
@hjmjohnson
STYLE: Remove python style warnings
32d8a43 
Shadow variable warnings, unused variable warnings
addressed.
@hjmjohnson hjmjohnson force-pushed the cleanup-sphinx-examples branch from a02e9f7 to 32d8a43 Compare December 25, 2021 15:58
@hjmjohnson hjmjohnson merged commit e474299 into master Dec 27, 2021
@dzenanz dzenanz deleted the cleanup-sphinx-examples branch December 27, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:Bridge Issues affecting the Bridge module area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module language:C++ Changes to C++ examples language:Python Changes to Python examples type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjmjohnson @dzenanz