Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Re-add coverage for itk::RegistrationParameterScales types #3406

Merged
merged 1 commit into from
May 3, 2022
Merged

BUG: Re-add coverage for itk::RegistrationParameterScales types #3406

merged 1 commit into from
May 3, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented May 2, 2022

Resolves InsightSoftwareConsortium/ITKSphinxExamples#349 in ITKSphinxExamples where itk.RegistrationParameterScalesFromPhysicalShift is wrapped only for itk.JensenHavrdaChandraTsallisPointSetToPointSetMetricv4 inputs that are templated over itk.PointSet[itk.SS,2].

Fixes template wrappings such that scales classes are templated over pointset-to-pointset metrics including real types (itk.F) and more than two dimensions if configured. Previously only the first template list entry was being parsed by the _add_pointset_types macro.

PR Checklist

Refer to the ITK Software Guide for
further development details if necessary.

@tbirdso tbirdso requested a review from brad-t-moore May 2, 2022 21:00
@github-actions github-actions bot added area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Coverage Code coverage impacts labels May 2, 2022
brad-t-moore
brad-t-moore approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@brad-t-moore brad-t-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the dashboard is green this looks good to me.

@tbirdso
Copy link
Contributor Author

tbirdso commented May 3, 2022

Dashboard is green 🟢 Merging.

@tbirdso tbirdso merged commit 77ea6d4 into InsightSoftwareConsortium:master May 3, 2022
This was referenced May 3, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-t-moore brad-t-moore brad-t-moore approved these changes

Assignees
No one assigned
Labels
area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Coverage Code coverage impacts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTest Failures
2 participants
@tbirdso @brad-t-moore